Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

convert image validator aspect ratio to list #2475

Merged
merged 1 commit into from
Sep 21, 2024

Conversation

sainak
Copy link
Member

@sainak sainak commented Sep 21, 2024

Proposed Changes

  • convert image validator aspect ratio to list
  • add tests

Merge Checklist

  • Tests added/fixed
  • Update docs in /docs
  • Linting Complete
  • Any other necessary step

Only PR's with test cases included and passing lint and test pipelines will be reviewed

@ohcnetwork/care-backend-maintainers @ohcnetwork/care-backend-admins

@sainak sainak requested a review from a team as a code owner September 21, 2024 09:38
Copy link

codecov bot commented Sep 21, 2024

Codecov Report

Attention: Patch coverage is 92.30769% with 1 line in your changes missing coverage. Please review.

Project coverage is 65.19%. Comparing base (664739e) to head (2de36a0).
Report is 1 commits behind head on develop.

Files with missing lines Patch % Lines
care/utils/models/validators.py 92.30% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #2475      +/-   ##
===========================================
+ Coverage    64.82%   65.19%   +0.37%     
===========================================
  Files          242      242              
  Lines        13858    13865       +7     
  Branches      1920     1925       +5     
===========================================
+ Hits          8983     9039      +56     
+ Misses        4497     4448      -49     
  Partials       378      378              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@bodhish bodhish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM;

@vigneshhari vigneshhari merged commit 51b5c00 into develop Sep 21, 2024
10 checks passed
@vigneshhari vigneshhari deleted the sainak/fix/image-validator branch September 21, 2024 10:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants