-
Notifications
You must be signed in to change notification settings - Fork 381
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added support for time in dateinput component #8504
base: develop
Are you sure you want to change the base?
Conversation
✅ Deploy Preview for care-ohc ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
CARE Run #3341
Run Properties:
|
Project |
CARE
|
Branch Review |
support-time-in-dateinput
|
Run status |
Passed #3341
|
Run duration | 03m 02s |
Commit |
3f52db1723: Added support for time in dateinput component
|
Committer | Shivank Kacker |
View all properties for this run ↗︎ |
Test results | |
---|---|
Failures |
0
|
Flaky |
0
|
Pending |
0
|
Skipped |
0
|
Passing |
128
|
View all changes introduced in this branch ↗︎ |
d387e4d
to
e62e655
Compare
…support-time-in-dateinput
Personal Note: Bro, instead of modifying the entire Cypress test to make it pass, try to understand the core problem of test fail. Then, debug it CC: @gigincg |
@shivankacker Bro, create a checklist of all the forms where you're changing the component and add it to the description. Review the functionality and responsiveness of each form one by one before requesting the next QA review. |
Will check and fix this one.
Screen.Recording.2024-09-13.at.9.31.58.PM.movBecause this behaviour was changed, the tests were also changed. Adding any format restrictions WHILE a user is typing would always result in these kind of issues.
cc. @gigincg |
…e some fixes for very edge cases
cc. @gigincg |
👋 Hi, @shivankacker, This message is automatically generated by prince-chrismc/label-merge-conflicts-action so don't hesitate to report issues/improvements there. |
Proposed Changes
DateInputV2
component.@ohcnetwork/care-fe-code-reviewers
Merge Checklist