Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: load swagger file from relative path #31

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

mo4islona
Copy link

@mo4islona mo4islona commented Apr 28, 2021

Fixes #32

@mo4islona mo4islona changed the title Load swagger file from relative path fix: load swagger file from relative path Apr 28, 2021
@ojoanalogo
Copy link
Owner

Hello, running the project with this changes breaks the ReDoc view when you are not working with a nginx server
We might need to do some adjustements like an option to toggle and load the file from a relative path

@ojoanalogo ojoanalogo added the bug Something isn't working label Apr 29, 2021
@mo4islona
Copy link
Author

Nice idea. Will update PR

@mo4islona
Copy link
Author

mo4islona commented Aug 12, 2021

I've found that easiest way is to redirect to path with trailing slash.

Also I migrate to joi package, @hapi/joi is deprecated now

And i've bumped up rxjs to 7 version — Nestjs 8 requires rxjs 7

@mo4islona mo4islona force-pushed the master branch 2 times, most recently from 5be143c to 8536041 Compare August 12, 2021 10:38
use "joi" package instead of deprecated "@hapi/joi"
@Azuka
Copy link

Azuka commented Oct 14, 2021

Just checking: when can this be released?

@mo4islona
Copy link
Author

Just checking: when can this be released?

https://www.npmjs.com/package/@mo4islona/nestjs-redoc

:)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cant load swagger file in Nest app running with url prefix
3 participants