chore(style): add editorconfig for easier configuration #1098
Conversation
Signed-off-by: Simon Schrottner <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1098 +/- ##
============================================
+ Coverage 95.09% 95.31% +0.21%
- Complexity 400 401 +1
============================================
Files 39 39
Lines 917 917
Branches 56 56
============================================
+ Hits 872 874 +2
+ Misses 24 23 -1
+ Partials 21 20 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
|
|
||
| # Following the rules of the Google Java Style Guide. | ||
| # See https://google.github.io/styleguide/javaguide.html | ||
| [*.java] |
There was a problem hiding this comment.
Is it possible to get a linter in CI which applies these same requirements? I'd prefer to not rely on someone's editor obeying this config for style correctness.
There was a problem hiding this comment.
There is still checkstyle in place, which enforces proper styling, but it reduces the pain for new contributors if they have a different code style setup in IntelliJ. For example I see regular people changing to star imports with auto-formatting - which does not need to be the case.
Many people struggle with their code styles when contributing for the first time. With this pull request, we're adding a .editorconfig to manage those settings in a centralized place, making everyone's lives easier.
With this iteration, we're adding IntelliJ Idea configuration.
The first commit contains the configuration, and I applied the second one to the whole code base.