Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add support for custom protocol dereffing #637

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

BelfordZ
Copy link
Member

@BelfordZ BelfordZ commented May 10, 2021

Enables options to be passed to both parseOpenRPCDocument & dereferenceDocument

fixes #587

CC json-schema-tools/reference-resolver#146

@codecov
Copy link

codecov bot commented May 10, 2021

Codecov Report

Merging #637 (20c7cc7) into master (b3e6711) will decrease coverage by 0.32%.
The diff coverage is 96.87%.

Impacted file tree graph

@@             Coverage Diff             @@
##            master     #637      +/-   ##
===========================================
- Coverage   100.00%   99.67%   -0.33%     
===========================================
  Files           12       12              
  Lines          307      305       -2     
  Branches        73       73              
===========================================
- Hits           307      304       -3     
- Misses           0        1       +1     
Impacted Files Coverage Δ
src/dereference-document.ts 98.79% <96.77%> (-1.21%) ⬇️
src/parse-open-rpc-document.ts 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b3e6711...20c7cc7. Read the comment docs.

@BelfordZ BelfordZ requested a review from shanejonas May 10, 2021 23:49
@stale
Copy link

stale bot commented Jul 13, 2021

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Jul 13, 2021
@stale stale bot closed this Jul 20, 2021
@shanejonas shanejonas reopened this Jul 21, 2021
@stale stale bot removed the stale label Jul 21, 2021
@raman-kananovich
Copy link

Hello @BelfordZ , thank you for this functionality! I have checked it in my case and it works really fine and completely covers my cases.

I found that dereferenceDocument function is only exposed in the node environment. Can I ask you to export it also for the web?

@stale
Copy link

stale bot commented Jun 13, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Jun 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Custom protocol support
3 participants