Implement stable database semantic conventions #11575
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
heyams
commented
Jun 13, 2024
.../opentelemetry/javaagent/instrumentation/lettuce/v5_0/LettuceConnectAttributesExtractor.java
Outdated
Show resolved
Hide resolved
github-actions
bot
added
the
test native
…base-stable-semconv
trask
reviewed
Aug 1, 2024
...main/java/io/opentelemetry/javaagent/instrumentation/cassandra/v3_0/CassandraSingletons.java
Outdated
Show resolved
Hide resolved
trask
reviewed
Aug 19, 2024
...pentelemetry/instrumentation/api/incubator/semconv/db/DbClientCommonAttributesExtractor.java
Outdated
Show resolved
Hide resolved
…base-stable-semconv
…base-stable-semconv
trask
reviewed
Sep 1, 2024
.../io/opentelemetry/instrumentation/api/incubator/semconv/db/SqlClientAttributesExtractor.java
Outdated
Show resolved
Hide resolved
...o/opentelemetry/instrumentation/api/incubator/semconv/db/DbClientCommonAttributesGetter.java
Show resolved
Hide resolved
...o/opentelemetry/instrumentation/api/incubator/semconv/db/DbClientCommonAttributesGetter.java
Show resolved
Hide resolved
...a/io/opentelemetry/instrumentation/api/incubator/semconv/db/DbClientAttributesExtractor.java
Outdated
Show resolved
Hide resolved
...a/io/opentelemetry/instrumentation/api/incubator/semconv/db/DbClientAttributesExtractor.java
Outdated
Show resolved
Hide resolved
...ava/io/opentelemetry/instrumentation/api/incubator/semconv/db/SqlClientAttributesGetter.java
Outdated
Show resolved
Hide resolved
...c/main/java/io/opentelemetry/instrumentation/api/incubator/semconv/rpc/RpcMetricsAdvice.java
Outdated
Show resolved
Hide resolved
…base-stable-semconv
|
I will add 'error.type' and the opt-in |
trask
reviewed
Sep 16, 2024
...java/io/opentelemetry/instrumentation/api/incubator/semconv/db/DbClientAttributesGetter.java
Outdated
Show resolved
Hide resolved
trask
reviewed
Sep 16, 2024
...o/opentelemetry/instrumentation/api/incubator/semconv/db/DbClientCommonAttributesGetter.java
Outdated
Show resolved
Hide resolved
trask
reviewed
Sep 16, 2024
...o/opentelemetry/instrumentation/api/incubator/semconv/db/DbClientCommonAttributesGetter.java
Show resolved
Hide resolved
trask
reviewed
Sep 16, 2024
Comment on lines
+159
to
+163
| SemconvStabilityUtil.getAttributeKey(DbIncubatingAttributes.DB_STATEMENT), | ||
| "SELECT *"), | ||
| entry( | ||
| SemconvStabilityUtil.getAttributeKey(DbIncubatingAttributes.DB_OPERATION), | ||
| "SELECT")); |
There was a problem hiding this comment.
I'd suggest changing these two lines to reference the stable names directly
There was a problem hiding this comment.
but we test both non-stable and stable. are you suggest to change gradle config to test stable only?
trask
reviewed
Sep 16, 2024
Comment on lines
+200
to
+206
| SemconvStabilityUtil.getAttributeKey(DbIncubatingAttributes.DB_STATEMENT), | ||
| "SELECT * FROM table"), | ||
| entry( | ||
| SemconvStabilityUtil.getAttributeKey(DbIncubatingAttributes.DB_OPERATION), | ||
| "SELECT"), | ||
| entry( | ||
| SemconvStabilityUtil.getAttributeKey(DbIncubatingAttributes.DB_CASSANDRA_TABLE), |
trask
reviewed
Sep 16, 2024
...tation-api/src/main/java/io/opentelemetry/instrumentation/api/internal/SemconvStability.java
Outdated
Show resolved
Hide resolved
trask
reviewed
Sep 16, 2024
| /** | ||
| * @deprecated Use {@link #getDbQueryText(REQUEST)} instead. | ||
| */ | ||
| @Deprecated | ||
| @Nullable | ||
| String getStatement(REQUEST request); |
There was a problem hiding this comment.
since this was just a rename, I think could add default implementation that delegates to getDbQueryText, then wouldn't need to override this everywhere
There was a problem hiding this comment.
it's better to use @deprecate so that when old semconv is removed, we can use it to clean it up.
| /** | ||
| * @deprecated Use {@link #getOperationName(REQUEST)} instead. | ||
| */ | ||
| @Deprecated | ||
| @Nullable | ||
| String getOperation(REQUEST request); |
There was a problem hiding this comment.
similar here could add default method calling getDbOperationName
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Protyping open-telemetry/semantic-conventions#1090