Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/update clarity #35

Merged
merged 5 commits into from
Jun 20, 2024
Merged

Feature/update clarity #35

merged 5 commits into from
Jun 20, 2024

Conversation

caparker
Copy link
Collaborator

No description provided.

Copy link
Member

@russbiggs russbiggs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

a few specific comments, then it just needs to meet all the linting rules

* @param {} key
*/
async function putFile(text, key) {
let fpath = `/home/christian/Downloads/${key}`;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This shoudl porbably be dynamic


const Providers = require('../lib/providers');
const { VERBOSE, request } = require('../lib/utils');
const { Sensor, SensorNode, SensorSystem } = require('../lib/station');
//const { Sensor, SensorNode, SensorSystem } = require('../lib/station');
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove commented out code

@russbiggs russbiggs merged commit 652026c into main Jun 20, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants