Bump docker version to fix tests in newer debian versions #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JulesLandrySimard
approved these changes
Jun 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
When trying to update our service base image to Debian 12 (bookworm), lint checks and tests fail to run in concourse.
The issue is docker-library/official-images#16829
Here's an example: https://concourse.managed.services.opendoor.com/teams/engineering/pipelines/prices/jobs/master-lint-checks/builds/2594#L6647de41:59
The solution is to update the version of docker. We run tests in the
dcind(docker compose in docker) image, which is ~5 years old. We already have a fork of it, so I just updated docker and docker compose.Test
Before: https://concourse.managed.services.opendoor.com/teams/engineering/pipelines/marketing/jobs/lint-tests/builds/260#L6647ee88:249
After: https://concourse.managed.services.opendoor.com/teams/engineering/pipelines/marketing/jobs/lint-tests/builds/269 (Yea, the lint checks failed, but the point is that they run)