Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add ORA filter for submission view rendering intervention #158

Merged
merged 1 commit into from
Apr 11, 2024

Conversation

BryanttV
Copy link
Contributor

@BryanttV BryanttV commented Apr 10, 2024

Description

This PR adds a filter to modify the default template of submissions in an ORA assignment.

  • New filter: ORASubmissionViewRenderStarted
  • New exception: RenderInvalidTemplate

Supporting Information

These changes are based on those proposed in the following ADR

@BryanttV BryanttV requested a review from a team as a code owner April 10, 2024 22:08
@openedx-webhooks
Copy link

Thanks for the pull request, @BryanttV! Please note that it may take us up to several weeks or months to complete a review and merge your PR.

Feel free to add as much of the following information to the ticket as you can:

  • supporting documentation
  • Open edX discussion forum threads
  • timeline information ("this must be merged by XX date", and why that is)
  • partner information ("this is a course on edx.org")
  • any other information that can help Product understand the context for the PR

All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here.

Please let us know once your PR is ready for our review and all tests are green.

@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Apr 10, 2024
@BryanttV BryanttV changed the title Bav/ora student view filter feat: add ORA filter for submission view rendering intervention #1 Apr 10, 2024
@BryanttV BryanttV changed the title feat: add ORA filter for submission view rendering intervention #1 feat: add ORA filter for submission view rendering intervention Apr 10, 2024
@BryanttV BryanttV force-pushed the bav/ora-student-view-filter branch from ae95cfb to e94df6a Compare April 11, 2024 13:32
@BryanttV
Copy link
Contributor Author

Hi @mariajgrimaldi, this PR is ready for review. The checks fail due to an error in the execution of the coverage workflow.

@mariajgrimaldi
Copy link
Member

You can rebase with main to fix the issue, thanks!

Copy link
Member

@mariajgrimaldi mariajgrimaldi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you so much! LGTM

Let me know when you rebase with main so I can merge.

@BryanttV BryanttV force-pushed the bav/ora-student-view-filter branch from 6c0e69c to 224bcf3 Compare April 11, 2024 22:39
@BryanttV
Copy link
Contributor Author

Hi @mariajgrimaldi, PR updated, thank you!

@mariajgrimaldi mariajgrimaldi merged commit bf1f702 into openedx:main Apr 11, 2024
9 checks passed
@openedx-webhooks
Copy link

@BryanttV 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
open-source-contribution PR author is not from Axim or 2U
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants