Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Issue 530 #633

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Conversation

nobeeakon
Copy link
Collaborator

@nobeeakon nobeeakon commented Jun 18, 2024

What

See #530

  • UI changes to the currency selector for Add single price. Button to edit + selector, instead of open a dialog and be redirected to the settings page.

Screenshot

image

@nobeeakon nobeeakon changed the title Issue 530 refactor: Issue 530 Jun 19, 2024
@raphodn
Copy link
Member

raphodn commented Jun 23, 2024

Some recent changes to the UI :

Not sure if we should add complexity in the proof/price add form. But rather redirect users to their settings page (currencies don't change very often...). And maybe one day have image detection, and or automatic currency setup depending on location

@nobeeakon
Copy link
Collaborator Author

think it is easier for the user to just select the currency they want, rather than being redirected to another page in the site to update this info and having to refresh the page (were they may have already added some information) to get the latest values. Besides that, don't think it is adding a lot of complexity, as is mostly some UI elements, and a couple of lines of code to the logic.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Backlog
Development

Successfully merging this pull request may close these issues.

3 participants