Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: Run API test with fresh UA each time, and randomize API test execution #10816

Closed
wants to merge 1 commit into from

Conversation

hangy
Copy link
Member

@hangy hangy commented Sep 20, 2024

What

Screenshot

Related issue(s) and discussion

  • Fixes #[ISSUE NUMBER]

Copy link

sonarcloud bot commented Sep 20, 2024

@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 83.33333% with 1 line in your changes missing coverage. Please review.

Project coverage is 49.07%. Comparing base (dc04d18) to head (e808a71).
Report is 658 commits behind head on main.

Files with missing lines Patch % Lines
lib/ProductOpener/APITest.pm 83.33% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #10816      +/-   ##
==========================================
- Coverage   49.54%   49.07%   -0.48%     
==========================================
  Files          67       77      +10     
  Lines       20650    22160    +1510     
  Branches     4980     5298     +318     
==========================================
+ Hits        10231    10874     +643     
- Misses       9131     9953     +822     
- Partials     1288     1333      +45     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@hangy
Copy link
Member Author

hangy commented Sep 21, 2024

This is related to what I talked about yesterday @john-gom. Interestingly, some integration tests are already failing with this change, so obviously can't merge as-is

@hangy
Copy link
Member Author

hangy commented Sep 23, 2024

Looks like this is fully intended. There are several tests that depend on the order of execution of the array to test that ie. a newly created product can be retrieved via the API directly. So I'll close this as "works as planned" 😄 For the Keycloak test, I'll try to a) separate auth tests from the other API tests, and b) try to replicate what happens when a wrong password is given when a user was previously signed in with correct data.

@hangy hangy closed this Sep 23, 2024
@hangy hangy deleted the integration-separation branch September 23, 2024 17:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants