Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initial checkin to resolve issue 373. #378

Merged
merged 4 commits into from
Mar 4, 2024

Conversation

pvretano
Copy link
Contributor

Closes #373

@pvretano pvretano marked this pull request as draft November 13, 2023 13:19
Copy link
Contributor

@fmigneault fmigneault left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The "Cardinality" chapter seems very appropriate to explain the current 1.0 behavior, but it contradicts with the updated examples that use the planned deprecation of maxOccurs.

core/examples/json/ProcessDescription.json Outdated Show resolved Hide resolved
core/sections/clause_6a_deprecated.adoc Outdated Show resolved Hide resolved
core/sections/clause_7_core.adoc Show resolved Hide resolved
core/sections/clause_7_core.adoc Outdated Show resolved Hide resolved
core/sections/clause_7_core.adoc Show resolved Hide resolved
@m-mohr
Copy link

m-mohr commented Feb 8, 2024

Is there a way to translate minOccurs/maxOccurs into a JSON Schema equivalent without them? If there is, it might help to have a note how to translate between them somewhere in the spec.

@jerstlouis
Copy link
Member

@m-mohr There is no equivalent for the use of minOccurs / maxOccurs as a JSON Schema, because individual process inputs which occur can be substituted by an href reference (or collection or process with Part 3).

The JSON Schema is for the actual value of an input, regardless of where it comes from (inline, as an href reference, or from a nested process). That's what I pointed out in #373 (comment) .

To clarify, in Processes-1, "by reference" inputs are NOT defined as one particular JSON schema possibility with an "href" property. Rather (like Part 3 process and collection), href is an alternative way to provide an input that corresponds to a JSON schema which describe what you will find inline or at that reference (or generated by that process / collection).

@pvretano pvretano marked this pull request as ready for review March 4, 2024 06:57
@bpross-52n bpross-52n merged commit 1788f27 into opengeospatial:master Mar 4, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Ambiguity around array inputs?
5 participants