Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extend HistoricItem to work with Instant instead of ZonedDateTime #4384

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

joerg1985
Copy link
Contributor

This PR will add a new default method to the HistoricItem interface, to get the timestamp as Instant.
The most areas using the HistoricItem must transform the internal Instant to a ZonedDateTime (e.g. all the persistence implementations) or need to transform the returned ZonedDateTime to an Instant (e.g. see the below).

So i my mind it does make sense to use a Instant here and not transform the data.
The link to the persistence implementations above does show the changes needed to the addons.

Signed-off-by: Jörg Sautter [email protected]

@joerg1985 joerg1985 requested a review from a team as a code owner September 18, 2024 09:59
@rkoshak
Copy link

rkoshak commented Sep 18, 2024

Will this be a breaking change for rules which currently expect a ZonedDateTime?

@joerg1985
Copy link
Contributor Author

@rkoshak no this is a none breaking change, the new method has a default implementation and all old methods are still in place.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants