Skip to content

Commit

Permalink
REPORT-899 ReportLoader should not set parameters to required=false b…
Browse files Browse the repository at this point in the history
…y default (#246)
  • Loading branch information
mseaton committed Aug 9, 2023
1 parent 237d85c commit f5f3cfc
Showing 1 changed file with 1 addition and 1 deletion.
Original file line number Diff line number Diff line change
Expand Up @@ -129,7 +129,7 @@ public static List<Parameter> constructParameters(List<ParameterDescriptor> para
p.setLabel(parameterDescriptor.getLabel());
p.setType(parameterType);
p.setDefaultValue(getParameterValue(parameterType, parameterDescriptor.getValue()));
p.setRequired(BooleanUtils.isTrue(parameterDescriptor.getRequired()));
p.setRequired(BooleanUtils.isNotFalse(parameterDescriptor.getRequired()));
parameters.add(p);
} catch (Exception e) {
throw new RuntimeException("Unable to configure parameter " + parameterDescriptor.getKey(), e);
Expand Down

0 comments on commit f5f3cfc

Please sign in to comment.