REPORT-635: Add startDate and endDate as configuration properties on … #193
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Did you take a look at the travis build failure? |
…RepeatPerTimePeriodDataSetDefinition
|
Yes I have am trying to make a sense of it |
Ruhanga
reviewed
Dec 16, 2019
There was a problem hiding this comment.
Looks like the failing tests originate from a single class, RepeatPerTimePeriodDataSetEvaluatorTest. Could you confirm this? They definitely fail with the introduced changes and may need careful refactoring to make them pass. You'll need to pay close attention to what is being tested. @ODORA0 could you take some deeper dive in to understand what the tests are actually verifying?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…RepeatPerTimePeriodDataSetDefinition
Issue worked on: https://issues.openmrs.org/browse/REPORT-635