REPORT-547:Delete The IndicatorReportRenderer #209
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The PR looks fine assuming we actually want to remove this class, which at this point I don't really see the value, given that it introduces some amount of backwards-incompatibility and issn't currently causing any issues by being here... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://issues.openmrs.org/browse/REPORT-547
WHAT I DID,
Removed indicatorReportRenderer class and its corresponding IndicatorReportRenderer class
This returned url return "/module/reporting/reports/renderers/nonConfigurableReportRenderer.form?type=" + rendererType.getName() has its own controller class so ideally this has no effect to jsp files
cc @dkayiwa @mseaton