metallbv2-add-connect-timer #666
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gkopels
force-pushed
the
metallb-add-bgppeer-connect-timer
branch
8 times, most recently
from
734fd28
to
e5cff99
Compare
evgenLevin
reviewed
Sep 16, 2024
pkg/metallb/bgppeer.go
Outdated
| } | ||
|
|
||
| glog.V(100).Infof( | ||
| "Creating BGPPeer %s in namespace %s with this holdTime: %s", |
There was a problem hiding this comment.
change holdTime to ConnectTime
|
|
||
| builder.errorMsg = "bgppeer 'connectTime' value is not valid" | ||
| } | ||
|
|
There was a problem hiding this comment.
please add
if builder.errorMsg != "" {
return builder
}
| @@ -397,8 +421,9 @@ func (builder *BGPPeerBuilder) WithNodeSelector(nodeSelector map[string]string) | |||
| return builder | |||
| } | |||
|
|
|||
| ndSelector := []mlbtypes.NodeSelector{{MatchLabels: nodeSelector}} | |||
| builder.Definition.Spec.NodeSelectors = ndSelector | |||
| builder.Definition.Spec.NodeSelectors = []metav1.LabelSelector{{ | |||
There was a problem hiding this comment.
What's the idea of this change?
There was a problem hiding this comment.
They changed it upstream in mlbtypesv1beta2
pkg/metallb/bgppeer_test.go
Outdated
| @@ -291,11 +329,6 @@ func TestBGPPeerWithNodeSelector(t *testing.T) { | |||
| testBGPPeer: buildValidBGPPeerBuilder(buildBGPPeerTestClientWithDummyObject()), | |||
| nodeSelector: map[string]string{"test": "test1"}, | |||
| }, | |||
| { | |||
| testBGPPeer: buildInValidBGPPeerBuilder(buildBGPPeerTestClientWithDummyObject()), | |||
There was a problem hiding this comment.
What's the idea of this change?
gkopels
force-pushed
the
metallb-add-bgppeer-connect-timer
branch
2 times, most recently
from
f94ecb2
to
08622f3
Compare
evgenLevin
reviewed
Sep 16, 2024
pkg/metallb/bgppeer.go
Outdated
| // WithNodeSelector defines the nodeSelector placed in the BGPPeer spec. | ||
| func (builder *BGPPeerBuilder) WithNodeSelector(nodeSelector map[string]string) *BGPPeerBuilder { | ||
| if valid, _ := builder.validate(); !valid { | ||
| return builder | ||
| } | ||
|
|
||
| if builder.errorMsg != "" { |
gkopels
force-pushed
the
metallb-add-bgppeer-connect-timer
branch
from
08622f3
to
3a98dbf
Compare
|
/lgtm |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding metallb connect timer. Connect timer is part of mlbtypesv1beta2