Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CNF-14425: Add timeout handling for hardware provisioning #213

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

tliu2021
Copy link
Collaborator

This update introduces timeout handling for node pool provisioning status. It tracks the start time of the hardware provisioning process, allowing the system to detect if it exceeds the configured timeout. If a timeout occurs,
it is reflected in the HardwareProvisioned condition of the cluster request.

Additionally, this update improves error handling by implementing requeue on errors and stopping requeue when provisioning has failed. A sample of hardware templates has also been included for reference.

This update introduces timeout handling for node pool provisioning status.
It tracks the start time of the hardware provisioning process, allowing
the system to detect if it exceeds the configured timeout. If a timeout
occurs, it is reflected in the HardwareProvisioned condition of the cluster
request.
Additionally, this update improves error handling by implementing requeue
on errors and stopping requeue when provisioning has failed.
A sample of hardware templates has also been included for reference.

Signed-off-by: Tao Liu <[email protected]>
@openshift-ci-robot
Copy link
Collaborator

openshift-ci-robot commented Sep 20, 2024

@tliu2021: This pull request references CNF-14425 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.18.0" version, but no target version was set.

In response to this:

This update introduces timeout handling for node pool provisioning status. It tracks the start time of the hardware provisioning process, allowing the system to detect if it exceeds the configured timeout. If a timeout occurs,
it is reflected in the HardwareProvisioned condition of the cluster request.

Additionally, this update improves error handling by implementing requeue on errors and stopping requeue when provisioning has failed. A sample of hardware templates has also been included for reference.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

Copy link

openshift-ci bot commented Sep 20, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from tliu2021. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants