Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MCO-52: add MCO API into openshift/api #1453

Merged
merged 10 commits into from
Sep 29, 2023
Merged

MCO-52: add MCO API into openshift/api #1453

merged 10 commits into from
Sep 29, 2023

Commits on Sep 28, 2023

  1. add mco api types and crds

    @jkyros
    jkyros committed Sep 28, 2023
    Configuration menu
    Copy the full SHA
    19779aa View commit details
    Browse the repository at this point in the history

  2. add management crd, tests for mco operator

    @jkyros
    jkyros committed Sep 28, 2023
    Configuration menu
    Copy the full SHA
    edca7b8 View commit details
    Browse the repository at this point in the history

  3. annotate all required/optional fields properly 

    This explicitly marks fields with optional/required in a way that
matches the original "requiredness" of the API in the MCO repo. Some of
these fields should probably be changed to required --
KubeletConfigCondition members for example should not be entirely
optional, but they always have been, and so for now we're going to leave
them set how they were. Later we can come back and fix them and see what
breaks.

This does set +kubebuilder:validation:Optional, but that's because we
historically have a field in ContinerRuntimeConfigSpec that was both
required in the CRD and tagged as omitempty in types.go and for now I'm
trying to preserve that until we can figure out if it's still necessary.
    @jkyros
    jkyros committed Sep 28, 2023
    Configuration menu
    Copy the full SHA
    659dcd1 View commit details
    Browse the repository at this point in the history

  4. add machineconfig tests for verify

    @jkyros
    jkyros committed Sep 28, 2023
    Configuration menu
    Copy the full SHA
    93d740a View commit details
    Browse the repository at this point in the history

  5. add mco types.go fields from recent MCO merges 

    - Adds cert details from machine-config-operator#3756
- Adds buildcontroller state from machine-config-operator#3731
- Adds image registry bundles from machine-config-operator#3770
- Adds internal registry pull secret from machine-config-operator#3806
    @jkyros
    jkyros committed Sep 28, 2023
    Configuration menu
    Copy the full SHA
    c247522 View commit details
    Browse the repository at this point in the history

  6. fix StaticPodOperatorStatus tag capitalization

    @jkyros
    jkyros committed Sep 28, 2023
    Configuration menu
    Copy the full SHA
    a7b5374 View commit details
    Browse the repository at this point in the history

  7. remove protobufs

    @jkyros
    jkyros committed Sep 28, 2023
    Configuration menu
    Copy the full SHA
    ad88a43 View commit details
    Browse the repository at this point in the history

  8. certificate time fields from string to metav1.Time

    @jkyros
    jkyros committed Sep 28, 2023
    Configuration menu
    Copy the full SHA
    6365217 View commit details
    Browse the repository at this point in the history

  9. tag MCO listTypes as atomic for schema verify

    @jkyros
    jkyros committed Sep 28, 2023
    Configuration menu
    Copy the full SHA
    0d78e89 View commit details
    Browse the repository at this point in the history

  10. make update

    @jkyros
    jkyros committed Sep 28, 2023
    Configuration menu
    Copy the full SHA
    545417a View commit details
    Browse the repository at this point in the history