-
Notifications
You must be signed in to change notification settings - Fork 363
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OCPBUGS-30122: chore: Bump to prometheus-operator 0.77 #2480
base: master
Are you sure you want to change the base?
Conversation
slashpai
commented
Sep 20, 2024
- I added CHANGELOG entry for this change.
- No user facing changes, so no entry in CHANGELOG was needed.
Signed-off-by: Jayapriya Pai <[email protected]>
@slashpai: This pull request references MON-4016 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.18.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: slashpai The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@@ -34,6 +34,8 @@ spec: | |||
- args: | |||
- --kubelet-service=kube-system/kubelet | |||
- --prometheus-config-reloader=quay.io/prometheus-operator/prometheus-config-reloader:v0.76.2 | |||
- --kubelet-endpoints=true | |||
- --kubelet-endpointslice=false |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ah we'd need to tweak the jsonnet a bit to remove the flag since it's not yet supported... Or try to merge the prometheus-operator bump before this one.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Aah that newly added in operator version right. We can try merging operator PR
@slashpai: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
/retitle OCPBUGS-30122: chore: Bump to prometheus-operator 0.77 |
@slashpai: This pull request references Jira Issue OCPBUGS-30122, which is valid. 3 validation(s) were run on this bug
Requesting review from QA contact: The bug has been updated to refer to the pull request using the external bug tracker. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |