Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP : RHDEVDOCS-6142 Fix Tekton Pipeline Management Commands #82312

Open
wants to merge 1 commit into
base: pipelines-docs-main
Choose a base branch
from

Conversation

hemantkumarc
Copy link

This PR is raised to achieve the expected results mentioned in the RHDEVDOCS-6142,

Version(s): pipelines-docs-1.14, pipelines-docs-1.15, pipelines-docs-1.16

Issue: RHDEVDOCS-6142

Link to docs preview:

QE review:

  • QE has approved this change.

@openshift-ci openshift-ci bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Sep 24, 2024
Copy link

openshift-ci bot commented Sep 24, 2024

Hi @hemantkumarc. Thanks for your PR.

I'm waiting for a openshift member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@hemantkumarc
Copy link
Author

@eromanova97. Can you please review my PR again ? I have closed the old PR and raised a new one.
cc : @Srivaralakshmi

@Srivaralakshmi
Copy link
Member

/ok-to-test

@openshift-ci openshift-ci bot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Sep 24, 2024
@Srivaralakshmi Srivaralakshmi added this to the Continuous Release milestone Sep 24, 2024
@ocpdocs-previewbot
Copy link

🤖 Tue Sep 24 10:21:03 - Prow CI generated the docs preview:

https://82312--ocpdocs-pr.netlify.app/openshift-pipelines/latest/tkn_cli/op-tkn-reference.html

Copy link

openshift-ci bot commented Sep 24, 2024

@hemantkumarc: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Copy link
Member

@Srivaralakshmi Srivaralakshmi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work! The changes look good to me except for the content type attribute. Please implement the suggestion given.

After L2, leave a line. Before L4, add this attribute:
:_mod-docs-content-type: REFERENCE

For more information, see: https://github.com/openshift/openshift-docs/blob/main/contributing_to_docs/doc_guidelines.adoc#content-type-attributes and https://github.com/openshift/openshift-docs/blob/main/contributing_to_docs/doc_guidelines.adoc#module-file-metadata

Thanks, @hemantkumarc.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. pipelines size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants