-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP : RHDEVDOCS-6142 Fix Tekton Pipeline Management Commands #82312
base: pipelines-docs-main
Are you sure you want to change the base?
WIP : RHDEVDOCS-6142 Fix Tekton Pipeline Management Commands #82312
Conversation
Hi @hemantkumarc. Thanks for your PR. I'm waiting for a openshift member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
@eromanova97. Can you please review my PR again ? I have closed the old PR and raised a new one. |
/ok-to-test |
🤖 Tue Sep 24 10:21:03 - Prow CI generated the docs preview: https://82312--ocpdocs-pr.netlify.app/openshift-pipelines/latest/tkn_cli/op-tkn-reference.html |
@hemantkumarc: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good work! The changes look good to me except for the content type attribute. Please implement the suggestion given.
After L2, leave a line. Before L4, add this attribute:
:_mod-docs-content-type: REFERENCE
For more information, see: https://github.com/openshift/openshift-docs/blob/main/contributing_to_docs/doc_guidelines.adoc#content-type-attributes and https://github.com/openshift/openshift-docs/blob/main/contributing_to_docs/doc_guidelines.adoc#module-file-metadata
Thanks, @hemantkumarc.
This PR is raised to achieve the expected results mentioned in the RHDEVDOCS-6142,
Version(s):
pipelines-docs-1.14
,pipelines-docs-1.15
,pipelines-docs-1.16
Issue: RHDEVDOCS-6142
Link to docs preview:
QE review: