Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TELCODOCS-1966 - update variables #82358

Merged
merged 1 commit into from
Sep 24, 2024
Merged

TELCODOCS-1966 - update variables #82358

merged 1 commit into from
Sep 24, 2024
+3 −3

Conversation

slovern
Copy link
Contributor

@slovern slovern commented Sep 24, 2024 •
edited
Loading

@openshift-ci openshift-ci bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Sep 24, 2024
@ocpdocs-previewbot
Copy link

🤖 Tue Sep 24 14:21:27 - Prow CI generated the docs preview:

https://82358--ocpdocs-pr.netlify.app/openshift-enterprise/latest/edge_computing/cnf-talm-for-cluster-upgrades.html

@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Sep 24, 2024

@slovern: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@josclark42
Copy link

/LGTM

@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Sep 24, 2024

@josclark42: changing LGTM is restricted to collaborators

In response to this:

/LGTM

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@slovern
Copy link
Contributor Author

slovern commented Sep 24, 2024

/label telco

@slovern
Copy link
Contributor Author

slovern commented Sep 24, 2024

/label peer-review-needed

@openshift-ci openshift-ci bot added telco Label for all Telco PRs peer-review-needed Signifies that the peer review team needs to review this PR labels Sep 24, 2024
@lpettyjo lpettyjo self-requested a review September 24, 2024 15:07
@lpettyjo lpettyjo added peer-review-in-progress Signifies that the peer review team is reviewing this PR branch/enterprise-4.17 and removed peer-review-needed Signifies that the peer review team needs to review this PR labels Sep 24, 2024
@lpettyjo lpettyjo added this to the Planned for 4.17 GA milestone Sep 24, 2024
lpettyjo
lpettyjo reviewed Sep 24, 2024
View reviewed changes
Copy link
Contributor

@lpettyjo lpettyjo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@lpettyjo lpettyjo added peer-review-done Signifies that the peer review team has reviewed this PR and removed peer-review-in-progress Signifies that the peer review team is reviewing this PR labels Sep 24, 2024
@slovern
Copy link
Contributor Author

slovern commented Sep 24, 2024

Thanks for the review @lpettyjo

@slovern
Copy link
Contributor Author

slovern commented Sep 24, 2024

/label merge-review-needed

@openshift-ci openshift-ci bot added the merge-review-needed Signifies that the merge review team needs to review this PR label Sep 24, 2024
@jab-rh jab-rh merged commit 945cc8e into openshift:main Sep 24, 2024
2 checks passed
@jab-rh
Copy link
Contributor

jab-rh commented Sep 24, 2024

/cherry-pick enterprise-4.17

@openshift-cherrypick-robot
Copy link

@jab-rh: new pull request created: #82381

In response to this:

/cherry-pick enterprise-4.17

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Sep 24, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lpettyjo lpettyjo lpettyjo left review comments

Assignees
No one assigned
Labels
branch/enterprise-4.17 merge-review-needed Signifies that the merge review team needs to review this PR peer-review-done Signifies that the peer review team has reviewed this PR size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. telco Label for all Telco PRs
Projects
None yet
Milestone
Planned for 4.17 GA
Development

Successfully merging this pull request may close these issues.
6 participants
@slovern @ocpdocs-previewbot @josclark42 @jab-rh @openshift-cherrypick-robot @lpettyjo