Add enable/disable endpoint methods #5095
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AntonKhorev
force-pushed
the
directions-endpoint-enable-disable
branch
from
ccbec6c
to
fe07f52
Compare
AntonKhorev
force-pushed
the
directions-endpoint-enable-disable
branch
from
fe07f52
to
5a1e3e5
Compare
|
Looks good to me, thanks. |
|
Merged as 99a7d21 |
|
Well actually it was the earlier version which was merged which is why github didn't detect the merge... Now I need to figure out the difference... |
|
Remerged as c5aa012 which I think just adds a missing abort call - something that I nearly asked about before the first merge! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #5064. I'm pulling it out because it's also required for #4900.
The noticeable difference after this PR should be geocoding request cancelling when leaving the directions page. Previously you could pick "Directions from/to here" then quickly close the directions form or go to any other map layout page. The geocoding request could terminate after that, placing an endpoint marker on the map despite not being on the directions page.