[57812] Changed CustomOptions to become a hierarchy #16749
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
apfohl
force-pushed
the
implementation/57812-add-model-and-data-migration
branch
from
4c77d3f
to
c67f653
Compare
akabiru
reviewed
Sep 18, 2024
| @@ -0,0 +1,16 @@ | |||
| class CreateCustomOptionHierarchies < ActiveRecord::Migration[7.1] | |||
| def change | |||
| create_table :custom_option_hierarchies, id: false do |t| | |||
There was a problem hiding this comment.
🟠 I would leave the id present- ActiveRecord won't play well with nil primary key. For example, #destroy won't work which means you can't leverage things like AR callbacks or the in-house DeleteService which relies on #destroy out of the box.
Of course you have the option to define composite primary keys but I've recently learnt the hard way the change in data structure can be messy
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket
https://community.openproject.org/projects/openproject/work_packages/57812/activity
What are you trying to accomplish?
Screenshots
What approach did you choose and why?
Merge checklist