Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GR-52034] Convert IGV to maven build and update to netbeans 22 #9645

Open
wants to merge 10 commits into
base: master
Choose a base branch
from

Conversation

graalvmbot
Copy link
Collaborator

This updates IGV to the latest netbeans 22 platform which officially supports JDK 17 through 22. This also converts the build to use maven which means you can use any IDE that supports maven to work on the IGV sources. The diff is huge because of renames so It's not easily reviewable except as a patch I think. I've tested it fairly well on my local machine but it would be nice to have some more guinea pigs. Checking out the branch and launching mx igv in the compiler suite should work to test it out.

@oracle-contributor-agreement oracle-contributor-agreement bot added the OCA Verified All contributors have signed the Oracle Contributor Agreement. label Sep 10, 2024
@tkrodriguez
Copy link
Member

@JaroslavTulach here the workign update to the latest netbeans platform. Maybe you can try it out and see if it resolves the problems you were having.

Also, the switch to maven has exposed some problems with the mx support in NetBeans interfering with open the maven based project. When I try to open IdealGraphVisualizer as a maven project from NetBeans 22, it properly recognizes the main maven pom.xml but it seems to think the modules are mx projects.
opendialog1
and opening the project shows that it's missing all the modules.

projects1

disabling the java-mx-project by editing $HOME/Library/Application Support/NetBeans/22/config/Modules/org-netbeans-modules-java-mx-project.xmlallows it to open correctly.

projects2

Any suggestions for working around this besides disabling that module?

@JaroslavTulach
Copy link
Contributor

Wow, 1135 changed files. That's out of any review possibilities.

use maven

Good step. Using Maven is the best way to develop a "NetBeans Platform" application with any IDE of one's choice. Good move!

@JaroslavTulach
Copy link
Contributor

JaroslavTulach commented Sep 18, 2024

@JaroslavTulach here the workign update to the latest netbeans platform. Maybe you can try it out and see if it resolves the problems you were having.

My biggest problem was too old APIs I had to use in my module in order to work in IGV. Getting NetBeans 22 APIs is great. Btw. version 23 should have already been released or is going to be out in few weeks.

Also, the switch to maven has exposed some problems with the mx support in NetBeans interfering with open the maven based project. When I try to open IdealGraphVisualizer as a maven project from NetBeans 22, it properly recognizes the main maven pom.xml but it seems to think the modules are mx projects.

We need to fix NetBeans java.mx.projects support!

disabling the java-mx-project by editing $HOME/Library/Application Support/NetBeans/22/config/Modules/org-netbeans-modules-java-mx-project.xmlallows it to open correctly.

There is a special support in java.mx.projects module to recognize "visualizer" modules. Most related issue I can find is apache/netbeans#2789 that code needs to be updated to recognize the new "Maven structure".

Any suggestions for working around this besides disabling that module?

Please don't workaround. Submit a patch for NetBeans to fix the issue.

@JaroslavTulach
Copy link
Contributor

Btw. there is detection of .mxignore file - maybe you can place it (into the root?) of maven project and convince the java.mx.projects module to ignore the Maven projects.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
OCA Verified All contributors have signed the Oracle Contributor Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants