-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[GR-52034] Convert IGV to maven build and update to netbeans 22 #9645
base: master
Are you sure you want to change the base?
Conversation
@JaroslavTulach here the workign update to the latest netbeans platform. Maybe you can try it out and see if it resolves the problems you were having. Also, the switch to maven has exposed some problems with the mx support in NetBeans interfering with open the maven based project. When I try to open IdealGraphVisualizer as a maven project from NetBeans 22, it properly recognizes the main maven pom.xml but it seems to think the modules are mx projects. disabling the java-mx-project by editing Any suggestions for working around this besides disabling that module? |
e41e048
to
7ba664d
Compare
7ba664d
to
018dfdb
Compare
Wow, 1135 changed files. That's out of any review possibilities.
Good step. Using Maven is the best way to develop a "NetBeans Platform" application with any IDE of one's choice. Good move! |
My biggest problem was too old APIs I had to use in my module in order to work in IGV. Getting NetBeans 22 APIs is great. Btw. version 23 should have already been released or is going to be out in few weeks.
We need to fix NetBeans
There is a special support in
Please don't workaround. Submit a patch for NetBeans to fix the issue. |
Btw. there is detection of .mxignore file - maybe you can place it (into the root?) of maven project and convince the |
This updates IGV to the latest netbeans 22 platform which officially supports JDK 17 through 22. This also converts the build to use maven which means you can use any IDE that supports maven to work on the IGV sources. The diff is huge because of renames so It's not easily reviewable except as a patch I think. I've tested it fairly well on my local machine but it would be nice to have some more guinea pigs. Checking out the branch and launching
mx igv
in the compiler suite should work to test it out.