Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GR-56098] Backport to 23.1: reachability-metadata.json parser #9670

Open
wants to merge 4 commits into
base: release/graal-vm/23.1
Choose a base branch
from

Conversation

loicottet
Copy link
Member

The goal of this PR is to enable the 23.1 version of GraalVM to correctly parse reachability metadata files emitted by GraalVM 24.1 and future releases. These files are parsed and matched to the existing capabilities of GraalVM 23.1 on a best effort basis, meaning that existing workflows won't be disrupted, but features introduced in subsequent versions will be ignored. For example, GraalVM 24.1 can register members (methods, fields and constructors) of proxy classes for reflection, which was not possible before, and does it via the reflection metadata instead of a separate proxy metadata file. When encountering such metadata, the 23.1 parser will now correctly register the proxy class for runtime instantiation, but won't enable reflective access to the specified members.
The PR is split in two commits to facilitate reviewing. The first one is a simple copy-paste of the parser from master (most of the contents of the com.oracle.svm.core.configure package) and the second contains the modifications required to make the parser fit with the features of 23.1.

@loicottet loicottet self-assigned this Sep 12, 2024
@oracle-contributor-agreement oracle-contributor-agreement bot added the OCA Required At least one contributor does not have an approved Oracle Contributor Agreement. label Sep 12, 2024
@oracle-contributor-agreement oracle-contributor-agreement bot added OCA Verified All contributors have signed the Oracle Contributor Agreement. and removed OCA Required At least one contributor does not have an approved Oracle Contributor Agreement. labels Sep 12, 2024
@loicottet loicottet force-pushed the lottet/backport-metadata-21 branch 2 times, most recently from 49a9261 to c8904a4 Compare September 12, 2024 09:24
@zakkak
Copy link
Collaborator

zakkak commented Sep 13, 2024

@fniephaus @ezzarghili shouldn't this be opened in https://github.com/graalvm/graalvm-community-jdk21u instead?

@fniephaus
Copy link
Member

shouldn't this be opened in https://github.com/graalvm/graalvm-community-jdk21u instead?

Yes, I think so.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport OCA Verified All contributors have signed the Oracle Contributor Agreement. redhat-interest
Projects
Status: To do
Development

Successfully merging this pull request may close these issues.

3 participants