Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hotfix: check msg is valid json to parse #909

Merged
merged 8 commits into from
Jun 28, 2023
Merged

Hotfix: check msg is valid json to parse #909

merged 8 commits into from
Jun 28, 2023

Conversation

trungbach
Copy link
Contributor

What is the purpose of these changes?

  • Try catch parse JSON message in proposal detail data

Brief changelog:
Documentation and Release Note

  • Does this PR introduces new features or user-facing behaviour changes? No
  • How is the feature or changes documented? No

lehieuhust
lehieuhust previously approved these changes Jun 19, 2023
@phutxorai
Copy link
Contributor

Hàm isJsonString nếu có thể dùng ở chỗ khác thì cần để ngoài global

@trungbach
Copy link
Contributor Author

Hàm isJsonString nếu có thể dùng ở chỗ khác thì cần để ngoài global

done ạ

@phutxorai
Copy link
Contributor

Hàm isJsonString nếu có thể dùng ở chỗ khác thì cần để ngoài global

done ạ

push vào develop để merge luôn thôi

chore: move isJsonString func to global helpers
@trungbach trungbach merged commit e29f9b5 into master Jun 28, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants