-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Hotfix: check msg is valid json to parse #909
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
trungbach
requested review from
lehieuhust,
ducphamle2,
haunv3,
phutxorai and
sonnx-oraichain
June 19, 2023 04:36
lehieuhust
previously approved these changes
Jun 19, 2023
Hàm isJsonString nếu có thể dùng ở chỗ khác thì cần để ngoài global |
sonnx-oraichain
previously approved these changes
Jun 19, 2023
done ạ |
push vào develop để merge luôn thôi |
chore: move isJsonString func to global helpers
trungbach
dismissed stale reviews from sonnx-oraichain and lehieuhust
via
June 19, 2023 08:15
9a42cfe
fix: add title list token & fix error time proposal
haunv3
approved these changes
Jun 28, 2023
lehieuhust
approved these changes
Jun 28, 2023
phutxorai
approved these changes
Jun 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of these changes?
Brief changelog:
Documentation and Release Note