feat: adds a workaround for a safari bug when loading modules async #617
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Safari currently has a bug where, if the same module is imported twice or more simultaneously, it fails with a reference error.
This is actually a Webkit bug and is registered here: WebKit/WebKit#24122
We don't know when this bug will be fixed, but we can work around it with a simple modification that prevents the same remote module from being imported twice. This PR implements this modification.
I'm not familiar with the source code of this lib, so I altered the function
__federation_import
everywhere I found it. Please, check.What is the purpose of this pull request?
Before submitting the PR, please make sure you do the following
fixes #123
).