Replace $.ajax() with fetch() #5925
Draft
+309
−253
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
asdil12
force-pushed
the
fetch
branch
6 times, most recently
from
e838560
to
9aed887
Compare
Martchus
reviewed
Sep 13, 2024
Martchus
reviewed
Sep 13, 2024
| @@ -23,6 +23,16 @@ function setupForAll() { | |||
| }); | |||
| } | |||
|
|
|||
| function getCSRFToken() { | |||
| return document.querySelector('meta[name="csrf-token"]').content; | |||
There was a problem hiding this comment.
Maybe it makes more sense to give this element an ID and use document.getElementById.
asdil12
force-pushed
the
fetch
branch
3 times, most recently
from
9f07f1a
to
0c65ba6
Compare
|
Looks generally good so from my side you could go ahead and change more places this way. |
asdil12
force-pushed
the
fetch
branch
13 times, most recently
from
4bc8f1a
to
7e08662
Compare
b10n1k
reviewed
Sep 19, 2024
assets/javascripts/comments.js
Outdated
| success: () => { | ||
| fetchWithCSRF(deleteButton.dataset.deleteUrl, {method: 'DELETE'}) | ||
| .then(response => { | ||
| if (response.status != 200) throw `Server returned ${response.status}: ${response.statusText}`; |
There was a problem hiding this comment.
Why response.status is limited on 200. I wonder if response.ok is more appropiate in those if https://developer.mozilla.org/en-US/docs/Web/API/Response/ok
b10n1k
reviewed
Sep 19, 2024
asdil12
force-pushed
the
fetch
branch
3 times, most recently
from
b507723
to
68bc207
Compare
asdil12
force-pushed
the
fetch
branch
5 times, most recently
from
ee75d64
to
7724f4a
Compare
Ticket: https://progress.opensuse.org/issues/166310 Co-authored-by: Martchus <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket: https://progress.opensuse.org/issues/166310