Various fixes #925
Merged
Various fixes #925
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thozza
force-pushed
the
fix-pkg-set-names
branch
from
edf1e33
to
8a41c77
Compare
mvo5
reviewed
Sep 12, 2024
thozza
force-pushed
the
fix-pkg-set-names
branch
from
8a41c77
to
7117cd2
Compare
The NewTestedDefault() was returning an empty repositories list when used within unit tests. And unfortunately, this didn't trigger any error and no test was checking that the list is not empty, in addition to checking the error. Modify `Reporegistry.New()` to return error if no repos were loaded. Modify the `NewTestedDefault()` to consistently determine the path to load repositories from, regardless of the situation in which it is being called. Signed-off-by: Tomáš Hozza <[email protected]>
Fix the test case to correctly skip RHEL-7 distros, after the loading of test distros has been fixed. Signed-off-by: Tomáš Hozza <[email protected]>
Remove the function from the ImageType interface, because it is not used anywhere and it just adds to the potential confusion. Signed-off-by: Tomáš Hozza <[email protected]>
thozza
force-pushed
the
fix-pkg-set-names
branch
from
7117cd2
to
f034e96
Compare
achilleas-k
approved these changes
Sep 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TestDistro_ManifestFIPSWarningPackageSetsChains(), because it was not used for anything.