Add initial support for generating SPDX SBOM documents (COMPOSER-2274) #930
+293
−30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thozza
requested review from
ondrejbudai,
mvo5,
achilleas-k,
schuellerf,
kingsleyzissou and
supakeen
thozza
force-pushed
the
sbom-poc
branch
3 times, most recently
from
fdd614e
to
9db4d0b
Compare
|
The PR is ready for review. |
|
The osbuild-composer test failures are expected (and not blocking), since the PR needs code changes to be integrated in osbuild-composer. |
achilleas-k
reviewed
Sep 19, 2024
schuellerf
reviewed
Sep 19, 2024
Update the ref to a version, which supports SBOM documents. Signed-off-by: Tomáš Hozza <[email protected]>
Add a new `sbom` package for working with SBOM documents. It provides a very simple wrapper struct, which currently supports only SPDX standard. The SBOM document is for now stored in a raw JSON form, to not have to convert the raw data from and to the specific in-memory representation on the worker. The idea is to provide a bit of an abstraction from the specific SBOM implementation, so that in the future, it would be possible to create `sbom.Document` from SBOM documents of various standards and also serialize it back to various SBOM standards. Signed-off-by: Tomáš Hozza <[email protected]>
Extend the `Solver.Depsolve()` method to allow requesting SBOM document for the depsolved transaction. In case an SBOM document is requested, a pointer to `sbom.Document` instance is returned with the depsolve result. Signed-off-by: Tomáš Hozza <[email protected]>
Since the number of the `Solver.Depsolve()` return values is slowly getting out of hands, introduce a `DepsolveResult` struct containing all of the return values. `Depsolve()` now returns a pointer to `DepsolveResult`. Signed-off-by: Tomáš Hozza <[email protected]>
Signed-off-by: Tomáš Hozza <[email protected]>
kingsleyzissou
approved these changes
Sep 19, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR depends on osbuild/osbuild#1818
sbompackage for working with SBOM documents.dnfjsonSolver.Depsolve()to support requesting SBOM documents for depsolved transactions.