Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

github: don't fail fast on Fedora unit tests #933

Merged
merged 1 commit into from
Sep 16, 2024

Conversation

achilleas-k
Copy link
Member

@achilleas-k achilleas-k commented Sep 16, 2024

Fedora 41 unit tests are currently failing due to an issue with the repositories and are non-essential for merging (which is common for rawhide and early branching periods).
However, the fail-fast property defaults to true, which causes the other Fedora tests to get cancelled when F41 fails.

Disable fail-fast so that F40 tests keep running when F41 tests fail.

This is the same change we made for CS tests
3b81a90 (#904)

This PR is simple but high priority for unblocking other PRs from merging.

Fedora 41 unit tests are currently failing due to an issue with
the repositories and are non-essential for merging (which is common for
rawhide and early branching periods).
However, the fail-fast property defaults to true, which causes the
other Fedora tests to get cancelled when F41 fails.

Disable fail-fast so that F40 tests keep running when F41 tests fail.

This is the same change we made for CS tests
3b81a90
Copy link
Contributor

@mvo5 mvo5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you

@achilleas-k achilleas-k added this pull request to the merge queue Sep 16, 2024
Merged via the queue into osbuild:main with commit 10b524d Sep 16, 2024
18 of 19 checks passed
@achilleas-k achilleas-k deleted the fedora-no-failfast branch September 16, 2024 11:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants