[RFC] gen-manifests: add excluded packages via exclude: prefix in mock
#938
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit adds excluded packages to the generated manifest when the `gen-manifests` command is run in the `mockDepsolve()` mode. This allows us to compare the generated otk and images manifests with more confidence.
mvo5
force-pushed
the
gen-manifests-mock-excludes
branch
from
234ad9e
to
fbde851
Compare
mvo5
changed the title
exclude- prefix in mockexclude: prefix in mock
mvo5
added a commit
to mvo5/osbuild-otk
that referenced
this pull request
Sep 18, 2024
This commit regenerates the reference images with the new `exclude:` prefix as outlined in osbuild/images#938
mvo5
added a commit
to mvo5/osbuild-otk
that referenced
this pull request
Sep 18, 2024
This commit follows osbuild/images#938 and adjust the way excludes are represented.
supakeen
reviewed
Sep 18, 2024
Maybe I'm misunderstanding what you are saying but if we just add the excluded package names as "normal" packages to the resolver we would not catch differences like "images" includes "pkg1" but "otk" excludes "pkg1". In both cases it would appear in the package list so I think we need some prefix/marker/thing that ensures they are different. Plus this is very explicit. But open for ideas of course. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds excluded packages to the generated manifest when the
gen-manifestscommand is run in themockDepsolve()mode.This allows us to compare the generated otk and images manifests with more confidence.