Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improve exception simplification #155

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

SoongNoonien
Copy link
Member

No description provided.

@SoongNoonien SoongNoonien force-pushed the exceptions branch 5 times, most recently from f0035e7 to 35d0ae5 Compare September 21, 2024 10:42
Copy link

codecov bot commented Sep 21, 2024

Codecov Report

Attention: Patch coverage is 76.36364% with 13 lines in your changes missing coverage. Please review.

Project coverage is 51.02%. Comparing base (78268ff) to head (8286245).

Files with missing lines Patch % Lines
src/ParameterExceptions.jl 79.48% 8 Missing ⚠️
src/GenericCyclotomicFractions.jl 66.66% 5 Missing ⚠️

❗ There is a different number of reports uploaded between BASE (78268ff) and HEAD (8286245). Click for more details.

HEAD has 1 upload less than BASE
Flag BASE (78268ff) HEAD (8286245)
4 3
Additional details and impacted files
@@             Coverage Diff             @@
##           master     #155       +/-   ##
===========================================
- Coverage   86.85%   51.02%   -35.84%     
===========================================
  Files          12       13        +1     
  Lines         928      931        +3     
===========================================
- Hits          806      475      -331     
- Misses        122      456      +334     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@SoongNoonien SoongNoonien force-pushed the exceptions branch 2 times, most recently from f16a562 to 92bbfce Compare September 21, 2024 12:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant