Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

also check for equal orderings in map_ideal #823

Merged
merged 3 commits into from
Sep 8, 2024
Merged

also check for equal orderings in map_ideal #823

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
45c2b66
also check for equal orderings in map_ideal
hannes14 Aug 21, 2024
e2b52fc
use new libsingular/Singular_jll
hannes14 Sep 6, 2024
781e488
new Singular_jll
hannes14 Sep 6, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions Project.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,8 +29,8 @@ Pidfile = "1.3"
Pkg = "1.6"
Random = "1.6"
RandomExtensions = "0.4.2"
Singular_jll = "~404.000.100"
Singular_jll = "~404.000.504"
Statistics = "1.6"
julia = "1.6"
lib4ti2_jll = "1.6.10"
libsingular_julia_jll = "~0.45.2"
libsingular_julia_jll = "~0.45.3"
16 changes: 15 additions & 1 deletion src/map/alghom.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,21 @@ function map_ideal(f::Map(SAlgHom), I::sideal)
f.ptr, f.codomain.ptr, libSingular.ndCopyMap())

J = Ideal(f.codomain,ptr)
J.isGB = I.isGB
# compare the orderings of f.domain.ptr and f.codomain.ptr
domain_ord=Cint[]
libSingular.rOrdering_helper(domain_ord, f.domain.ptr)
codomain_ord=Cint[]
libSingular.rOrdering_helper(codomain_ord, f.codomain.ptr)
equal_ordering=true
for i in 1:size(domain_ord,1)
if domain_ord[i] != codomain_ord[i]
equal_ordering=false
break
end
end
if equal_ordering
J.isGB = I.isGB
end
return J
end

Expand Down
Loading