v2 #144
Merged
v2 #144
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The preformance of this is approximately the same as the net.IP version, except for the methods that return a network. For those, there is a slight improvement.
This makes it easier to extend without adding many different lookup methods.
This is more ergonomic than creating a struct for a single value and the performance is better as well due to less reflection: BenchmarkDecodeCountryCodeWithStruct-8 1347441 882.4 ns/op 1 B/op 0 allocs/op BenchmarkDecodePathCountryCode-8 2708011 445.1 ns/op 1 B/op 0 allocs/op
It is somewhat arbitrary, especially when dealing with switch statements and code may be inlined for performance reasons.
In order to make it easier to refactor and optimize.
Slice length of 64 is used as most IPv6 trees will have that as their maximum depth.
The comment on "iter" is because the linter was not stable and kept on shifting it every time it ran.
And replace it with (*Reader).LookupOffset
To more closely match net/netip. Also, it may reduce confusion with Networks and NetworksWithin, which refer to more than just the network.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #141