Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🥅 Throw a more useful message when subtypes are not invertible #45

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

🥅 Throw a more useful message when subtypes are not invertible #45

wants to merge 1 commit into from
+3 −0

Commits on Oct 5, 2021

  1. 🥅 Throw a more useful message when subtypes are not invertible 

    The `invert()` method assumes that all subtypes are invertible. However,
the OT type `invert()` method is [optional][1], so not all types will
have it implemented (`rich-text` is a notable example).

This change checks for presence of the `invert()` function, and throws
a more descriptive error if it's not present.

[1]: https://github.com/ottypes/docs#optional-properties
    @alecgibson
    alecgibson committed Oct 5, 2021
    Configuration menu
    Copy the full SHA
    1035818 View commit details
    Browse the repository at this point in the history