Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: add python 3.12 in test workflow #69

Merged

Conversation

Danyal-Faheem
Copy link
Contributor

@Danyal-Faheem Danyal-Faheem commented Feb 28, 2024

The plugin was already compatible with Python 3.12 after this commit.

I have just updated the workflows for both python 3.8 and python 3.12 as mentioned here

However, the dockerfile is still to be updated for python 3.12.

@Danyal-Faheem Danyal-Faheem marked this pull request as draft February 29, 2024 13:05
@Danyal-Faheem
Copy link
Contributor Author

Marking this as a draft as tutor-mfe needs to be upgraded to 3.12 as a prerequisite first.

@Danyal-Faheem Danyal-Faheem marked this pull request as ready for review March 12, 2024 11:12
@Danyal-Faheem Danyal-Faheem force-pushed the danyalfaheem/upgrade-to-python-3.12 branch from b3efab8 to 5aa717b Compare March 13, 2024 10:08
Copy link
Collaborator

@Faraz32123 Faraz32123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Faraz32123 Faraz32123 merged commit 665bc18 into overhangio:master Mar 19, 2024
2 checks passed
@Danyal-Faheem Danyal-Faheem deleted the danyalfaheem/upgrade-to-python-3.12 branch April 15, 2024 11:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

2 participants