Fix Noise in UDN

We kept trying to add the management port for secondary networks into the cluster port group of secondary networks. But that port group doesn't exist yet. It will exist once we get #4547 merged but until then this is causing infinite retries from syncMgmtPort erroring out. Signed-off-by: Surya Seetharaman <[email protected]>
ovn-org · Sep 19, 2024 · 6662803 · 6662803
1 parent 8017e9a
commit 6662803
Showing 1 changed file with 8 additions and 5 deletions.
diff --git a/go-controller/pkg/ovn/base_network_controller.go b/go-controller/pkg/ovn/base_network_controller.go
@@ -670,11 +670,14 @@ func (bnc *BaseNetworkController) syncNodeManagementPort(node *kapi.Node, switch
 		return nil, err
 	}
 
-	// TODO(dceara): The cluster port group must be per network.
-	err = libovsdbops.AddPortsToPortGroup(bnc.nbClient, bnc.getClusterPortGroupName(types.ClusterPortGroupNameBase), logicalSwitchPort.UUID)
-	if err != nil {
-		klog.Errorf(err.Error())
-		return nil, err
+	// TODO(dceara): The cluster port group must be per network. So for now skip adding management port
+	// for secondary network's because the cluster port group is not yet created for secondary networks.
+	if !bnc.IsSecondary() {
+		err = libovsdbops.AddPortsToPortGroup(bnc.nbClient, bnc.getClusterPortGroupName(types.ClusterPortGroupNameBase), logicalSwitchPort.UUID)
+		if err != nil {
+			klog.Errorf(err.Error())
+			return nil, err
+		}
 	}
 
 	if v4Subnet != nil {