Signed-off-by: Dan Williams <[email protected]>

Used when we absolutely do not want to create the object (like a bridge)
if it doesn't exist, because that should be a hard error, but just want
to update it. Mostly to make sure testcases do the right thing, but we
never actually want to create 'br-int' either, so it works for both
testcases and real code.

Signed-off-by: Dan Williams <[email protected]>

Complement to Lookup() for chained operations.

Signed-off-by: Dan Williams <[email protected]>

Signed-off-by: Dan Williams <[email protected]>

Signed-off-by: Dan Williams <[email protected]>

cmdAdd/cmdDel use similar setup code; consolidate it. Also make
cmdAdd use the same error logging mechanism as cmdDel does.

Signed-off-by: Dan Williams <[email protected]>

Signed-off-by: Jaime Caamaño Ruiz <[email protected]>

Signed-off-by: Jaime Caamaño Ruiz <[email protected]>

This is handled the same for all networks so it makes sense for it to be
at the base handler

Signed-off-by: Jaime Caamaño Ruiz <[email protected]>

We will introduce a specific layer2 event handler and the current name
for the base layer 2 event handler (shared between layer2 and localnet
controllers) would collide, so rename it.

Signed-off-by: Jaime Caamaño Ruiz <[email protected]>

Instead of having sommon Start/Stop entry points in the base layer2
controller, let the layer2 and localnet controllers have their own so
that they are in full control on how they start or stop.

Signed-off-by: Jaime Caamaño Ruiz <[email protected]>

Layer2 controller needs to be aware the node's zones so it needs to
handle node events thorugh its own event handler.

Signed-off-by: Jaime Caamaño Ruiz <[email protected]>

Currently in use by the default & layer 3 network controllers, the
zoneICHandler will also be used by the layer2 network controller in
sections of the code that are shared accross all controllers.

Signed-off-by: Jaime Caamaño Ruiz <[email protected]>

All network IDs are annotated to all nodes and the layer2 network
controller will need it in context of no particular node.

Signed-off-by: Jaime Caamaño Ruiz <[email protected]>

There are three aspects worth highlighting:

* Support is achieved through specific configuration of the logical
  switch and logical ports that the layer2 network controller was
  already owner of. As such, the IC handler does provide this specific
  configuration but does not add, delete or clean up those entries which
  is still done by the network controller.

* The base layer 2 controller does no longer handle local or remote pod
  events in different code flows. This commit brings them together as
  the only difference between them is whether they create the remote
  port (layer2) or not (localnet). I did try different things but this
  was the easiest way forward at this time by at least an order
  of magnitude amount of effort.

* This commit also brings together layer3 and layer2 pod synchronization
  as there were not that many differences between them.

Signed-off-by: Jaime Caamaño Ruiz <[email protected]>

Signed-off-by: Jaime Caamaño Ruiz <[email protected]>

Signed-off-by: Jaime Caamaño Ruiz <[email protected]>

Commit 5d6b136 added child stop channels to stop the network policy
handlers independently from the network controller when the policy is
deleted while also stopping them if the network controller is stopped.

Unfortunately when both things happen at the same time, one of those
events will end up attempting to close a closed channel which will panic.

Introduce a CancelableContext utility that will wrap a cancelable context
that can be chained to achieve the same effect.

Signed-off-by: Jaime Caamaño Ruiz <[email protected]>

Signed-off-by: Jaime Caamaño Ruiz <[email protected]>

This would remove node name comparison between cloud private ip config
and egress ip status as this is not valid in the case of egress ip
failover to another node during upgrade or reboot scenario.

Signed-off-by: Periyasamy Palanisamy <[email protected]>

After live migrating a VM the original node can be shutdown and a new
one can appear taking over the node subnet. There were some unit tets
for that but they exercise this part for non live migration scenarios
creating a race condition between cleanup and addLogicalPort.

This change run that part of the tests only for live-migration
scenarios.

Signed-off-by: Enrique Llorente <[email protected]>

…ed before creating a new pod networking

Do not try to configure the OVS, if the interface matching the iface-id cannot be garbage-collected.
Otherwise pods might enter the CrashLoopBackOff state, because the related ct-zone disappears from the bridge interface.

Signed-off-by: Rafael Chicoli <[email protected]>