Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ANP: Add Support for Networks as Egress Peers #4235

Merged
merged 6 commits into from
Apr 22, 2024
Merged

ANP: Add Support for Networks as Egress Peers #4235

merged 6 commits into from
Apr 22, 2024

Commits on Apr 22, 2024

  1. Fix nit in log statement 

    Signed-off-by: Surya Seetharaman <[email protected]>
    @tssurya
    tssurya committed Apr 22, 2024
    Configuration menu
    Copy the full SHA
    2bc35d8 View commit details
    Browse the repository at this point in the history

  2. AddressSetUtils: Change []net.IP to []string 

    OVN Address-Sets can be a combination of IPs, CIDRs, Ethernet
addresses etc as specified in their documentation:
" An address set may contain Ethernet, IPv4, or IPv6 addresses with
 optional bitwise or CIDR masks."

_uuid               : 642413a7-21c6-42a5-a817-db9d31455716
addresses           : ["10.244.0.3", "10.244.0.4", "10.244.0.5", "10.244.1.3", "10.244.2.3", "10.244.3.0/24", "172.19.0.3", "172.19.0.4", "172.19.0.5"]
external_ids        : {direction=Egress, gress-index="1", ip-family=v4, "k8s.ovn.org/id"="default-network-controller:AdminNetworkPolicy:node-as-egress-peers:Egress:1:v4", "k
8s.ovn.org/name"=node-as-egress-peers, "k8s.ovn.org/owner-controller"=default-network-controller, "k8s.ovn.org/owner-type"=AdminNetworkPolicy}
name                : a2074424610294966262

However our ovn pkg address-sets were all IP centric using
net.IP everywhere. This refactor will help in future commits
where we plan to add CIDR peers as well.

NOTE: Reviweres please take care to ensure I haven't removed
some ParseCIDR/ParseIP validations which could cause some
regressions or issues.

Updated mockery to 2.40 version and ran mockery --all in
the address-set package.

Signed-off-by: Surya Seetharaman <[email protected]>
    @tssurya
    tssurya committed Apr 22, 2024
    Configuration menu
    Copy the full SHA
    7c63749 View commit details
    Browse the repository at this point in the history

  3. ANP: Add support for CIDR peers 

    Signed-off-by: Surya Seetharaman <[email protected]>
    @tssurya
    tssurya committed Apr 22, 2024
    Configuration menu
    Copy the full SHA
    78596ce View commit details
    Browse the repository at this point in the history

  4. ANP: Add UT for networks peer 

    Signed-off-by: Surya Seetharaman <[email protected]>
    @tssurya
    tssurya committed Apr 22, 2024
    Configuration menu
    Copy the full SHA
    b9a5ae4 View commit details
    Browse the repository at this point in the history

  5. Add e2e tests for node and cidr peers 

    Signed-off-by: Surya Seetharaman <[email protected]>
    @tssurya
    tssurya committed Apr 22, 2024
    Configuration menu
    Copy the full SHA
    4ee8137 View commit details
    Browse the repository at this point in the history

  6. Bump network-policy-api to 0.1.5 

    Signed-off-by: Surya Seetharaman <[email protected]>
    @tssurya
    tssurya committed Apr 22, 2024
    Configuration menu
    Copy the full SHA
    e43ae38 View commit details
    Browse the repository at this point in the history