Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport E2E fixes #4742

Open
wants to merge 14 commits into
base: release-1.0
Choose a base branch
from

Commits on Sep 19, 2024

  1. Services E2Es: Reset test variables before each test

    Fixes: ovn-org#4733
    
    Signed-off-by: Patryk Diak <[email protected]>
    (cherry picked from commit d6f145e)
    kyrtapz committed Sep 19, 2024
    Configuration menu
    Copy the full SHA
    da710de View commit details
    Browse the repository at this point in the history

Commits on Sep 20, 2024

  1. egressfirewall: avoid nil dereference on node delete

    Signed-off-by: Nadia Pinaeva <[email protected]>
    (cherry picked from commit ab00a4b)
    npinaeva authored and kyrtapz committed Sep 20, 2024
    Configuration menu
    Copy the full SHA
    7d1f869 View commit details
    Browse the repository at this point in the history
  2. e2e: Add applyEF function

    Signed-off-by: Nadia Pinaeva <[email protected]>
    (cherry picked from commit ba8766a)
    npinaeva authored and kyrtapz committed Sep 20, 2024
    Configuration menu
    Copy the full SHA
    cebf08e View commit details
    Browse the repository at this point in the history
  3. e2e: add checkConnectivity functions for EF tests.

    Update connectivity timeout to 3 seconds and allow 2 retries both for
    positive and negative cases
    
    Signed-off-by: Nadia Pinaeva <[email protected]>
    (cherry picked from commit 09b08ec)
    npinaeva authored and kyrtapz committed Sep 20, 2024
    Configuration menu
    Copy the full SHA
    2e105cb View commit details
    Browse the repository at this point in the history
  4. e2e: use external containers for EF connectivity checks to make it

    work with ipv6, since github runners don't have any routes for IPv6.
    Split current test that checks allow IP and allow CIDR+port into 2
    tests to limit the amount of required external containers.
    Bonus: the only test that used external containers doesn't need to
    create them anymore, as they are created in beforeEach
    
    Signed-off-by: Nadia Pinaeva <[email protected]>
    (cherry picked from commit 2372a08)
    npinaeva authored and kyrtapz committed Sep 20, 2024
    Configuration menu
    Copy the full SHA
    7a2daaf View commit details
    Browse the repository at this point in the history
  5. e2e: move tests using external containers into their own context to

    avoid unneeded container creation. No extra changes
    
    Signed-off-by: Nadia Pinaeva <[email protected]>
    (cherry picked from commit 82b2bf1)
    npinaeva authored and kyrtapz committed Sep 20, 2024
    Configuration menu
    Copy the full SHA
    422f5fa View commit details
    Browse the repository at this point in the history
  6. e2e: Add EF test to make sure internal connections (pod2pod) are not

    affected by deny all.
    
    Signed-off-by: Nadia Pinaeva <[email protected]>
    (cherry picked from commit ded63dd)
    npinaeva authored and kyrtapz committed Sep 20, 2024
    Configuration menu
    Copy the full SHA
    1838308 View commit details
    Browse the repository at this point in the history
  7. e2e: add chais test before node test.

    To verify no deadlock, we need an intensive follow up workload.
    Node-selector testing work the best, as node events handling includes
    iterating over all egress firewalls internally.
    
    Signed-off-by: Nadia Pinaeva <[email protected]>
    (cherry picked from commit e2f4c74)
    npinaeva authored and kyrtapz committed Sep 20, 2024
    Configuration menu
    Copy the full SHA
    1ad8c43 View commit details
    Browse the repository at this point in the history
  8. e2e: move node2ndaryIPs-related functionality to the only test case

    that needs it. Use defer to cleanup instead of afterEach, as afterEach
    should cleanup resources created by beforeEach.
    
    Signed-off-by: Nadia Pinaeva <[email protected]>
    (cherry picked from commit 217ec65)
    npinaeva authored and kyrtapz committed Sep 20, 2024
    Configuration menu
    Copy the full SHA
    230ea3d View commit details
    Browse the repository at this point in the history
  9. e2e: remove duplicated functionality from the node-selector tests.

    Remove unneeded external IPs from the deadlock test, as multiple
    unresolvable ds names is the main ingredient.
    Fix ip:port formatting for ipv6.
    
    Signed-off-by: Nadia Pinaeva <[email protected]>
    (cherry picked from commit 3fac0f3)
    npinaeva authored and kyrtapz committed Sep 20, 2024
    Configuration menu
    Copy the full SHA
    34ac5fc View commit details
    Browse the repository at this point in the history
  10. e2e: remove egressfirewall from ipv6 exceptions

    Signed-off-by: Nadia Pinaeva <[email protected]>
    (cherry picked from commit 243c48d)
    npinaeva authored and kyrtapz committed Sep 20, 2024
    Configuration menu
    Copy the full SHA
    f32c68f View commit details
    Browse the repository at this point in the history
  11. e2e: go mod tidy

    Signed-off-by: Nadia Pinaeva <[email protected]>
    (cherry picked from commit 8c1e9ed)
    npinaeva authored and kyrtapz committed Sep 20, 2024
    Configuration menu
    Copy the full SHA
    b09216d View commit details
    Browse the repository at this point in the history
  12. Adds e2e test: conntrack flush after ovnkube delete

    Test opens a TCP connection that simulates a GCP LB environment where
    the packet is redirected via iptables to a local server on a node. Note,
    in GCP the LB does not DNAT the VIP, so the packet arrives to the node
    with the GCP VIP on it. In OCP, we then redirect that packet to the
    local kapi server running on the node.
    
    Once the test opens the TCP connection, it leaves it open for 2 minutes
    while ovnkube-node is then deleted. Post ovn-controller starting it
    should not flush the conntrack in zone 0, and the test ensures that the
    conntrack entry still exists.
    
    Recent OVN regression that prompted this E2E: https://issues.redhat.com/browse/FDP-773
    
    NOTE: The release-1.0 backport generated conflicts because on that
    branch the test didn't check IPv6.
    
    Signed-off-by: Tim Rozet <[email protected]>
    (cherry picked from commit 45abadb)
    Signed-off-by: Dumitru Ceara <[email protected]>
    trozet authored and kyrtapz committed Sep 20, 2024
    Configuration menu
    Copy the full SHA
    514d5cf View commit details
    Browse the repository at this point in the history
  13. e2e: Fix secondaryIPV6Subnet mask

    The previous mask was invalid and docker was failing with:
    invalid subnet 2001:db8:abcd:1234:c000::/64: it should be 2001:db8:abcd:1234::/64
    
    Signed-off-by: Patryk Diak <[email protected]>
    (cherry picked from commit 511e9c6)
    kyrtapz committed Sep 20, 2024
    Configuration menu
    Copy the full SHA
    10fed55 View commit details
    Browse the repository at this point in the history