Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[TECHNICAL] Rely on resharing capability #4472

Merged
merged 8 commits into from
Sep 24, 2024
Merged

[TECHNICAL] Rely on resharing capability #4472

merged 8 commits into from
Sep 24, 2024

Conversation

JuancaG05
Copy link
Collaborator

@JuancaG05 JuancaG05 commented Sep 20, 2024 •
edited
Loading

Related Issues

App: #4397

  • Add changelog files for the fixed issues in folder changelog/unreleased. More info here
  • Add feature to Release Notes in ReleaseNotesViewModel.kt creating a new ReleaseNote() with String resources (if required)

QA

@JuancaG05 JuancaG05 self-assigned this Sep 20, 2024
@JuancaG05 JuancaG05 linked an issue Sep 20, 2024 that may be closed by this pull request
[TECHNICAL] Rely on resharing capability #4397
Closed
10 tasks
@JuancaG05 JuancaG05 changed the title [TECHNICAL] Rely on resharing capability for oCIS accounts [TECHNICAL] Rely on resharing capability for oCIS accounts Sep 20, 2024
@JuancaG05 JuancaG05 changed the title [TECHNICAL] Rely on resharing capability for oCIS accounts [TECHNICAL] Rely on resharing capability Sep 20, 2024
@JuancaG05 JuancaG05 force-pushed the technical/rely_on_resharing_capability_ocis branch from 95e3426 to cbb1656 Compare September 23, 2024 06:22
Aitorbp
Aitorbp requested changes Sep 23, 2024
View reviewed changes
Copy link
Collaborator

@Aitorbp Aitorbp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a comment and go

owncloudApp/src/main/res/values/strings.xml Outdated Show resolved Hide resolved
Aitorbp
Aitorbp approved these changes Sep 23, 2024
View reviewed changes
Copy link
Collaborator

@Aitorbp Aitorbp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🥇

@jesmrec
Copy link
Collaborator

jesmrec commented Sep 23, 2024 •
edited
Loading

Some checks here:

Tested with 3 different servers:

  • oCIS with resharing: true
  • oCIS with resharing: false
  • oC10 (both values of resharing)
  1. resharing: true
  • Sharing file with all permissions -> permissions: 19 in request + 19 in response + all permissions available in UI
  • Sharing folder with all permissions -> permissions: 31 in request + 31 in response + all permissions available in UI
  1. resharing: false
  • Sharing file with all permissions -> permissions: 3 in request + 3 in response + only edit permission available in UI
  • Sharing folder with all permissions -> permissions: 15 in request + 15 in response + only edit permissions available in UI with subpermissions

@JuancaG05 JuancaG05 force-pushed the technical/rely_on_resharing_capability_ocis branch from 3244bb5 to e3707c6 Compare September 23, 2024 13:01
@jesmrec
Copy link
Collaborator

jesmrec commented Sep 24, 2024

Everything passed. OK from my side

@jesmrec jesmrec force-pushed the technical/rely_on_resharing_capability_ocis branch from e3707c6 to 22457f4 Compare September 24, 2024 11:16
@jesmrec jesmrec merged commit fd4b375 into master Sep 24, 2024
7 checks passed
@jesmrec jesmrec deleted the technical/rely_on_resharing_capability_ocis branch September 24, 2024 11:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Aitorbp Aitorbp Aitorbp approved these changes

Assignees

@JuancaG05 JuancaG05

Labels
Approved by qa
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[TECHNICAL] Rely on resharing capability
3 participants
@JuancaG05 @jesmrec @Aitorbp