Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add initial implementation of SecuritesService #24

Merged
merged 6 commits into from
Apr 16, 2023
Merged

Conversation

oxisto
Copy link
Owner

@oxisto oxisto commented Apr 14, 2023

Fixes #14

@codecov
Copy link

codecov bot commented Apr 14, 2023

Codecov Report

Merging #24 (8148f61) into main (040d29a) will increase coverage by 5.07%.
The diff coverage is 73.84%.

@@            Coverage Diff             @@
##             main      #24      +/-   ##
==========================================
+ Coverage   66.66%   71.73%   +5.07%     
==========================================
  Files           2        4       +2     
  Lines          27       92      +65     
==========================================
+ Hits           18       66      +48     
- Misses          6       21      +15     
- Partials        3        5       +2     
Flag Coverage Δ
unittests 71.73% <73.84%> (+5.07%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
internal/assert/assert.go 50.00% <50.00%> (ø)
service/securities/service.go 80.39% <80.39%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@oxisto oxisto marked this pull request as ready for review April 16, 2023 16:45
@oxisto oxisto merged commit 5e2e7ad into main Apr 16, 2023
@oxisto oxisto deleted the securities-service branch April 16, 2023 16:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The SecuritiesService
1 participant