Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create publish-gem.yml #405

Merged
merged 5 commits into from
Jan 16, 2024
Merged

Create publish-gem.yml #405

merged 5 commits into from
Jan 16, 2024

Conversation

tsusdere
Copy link
Contributor

@tsusdere tsusdere commented Jan 2, 2024

Add workflow for auto-publishing gem

Copy link

welcome bot commented Jan 2, 2024

Welcome! Congrats on your first pull request to the Minimal theme. If you haven't already, please be sure to check out the contributing guidelines.

Copy link

request-info bot commented Jan 2, 2024

Thanks for this. Do you mind providing a bit more information about what problem you're trying to solve?

@tsusdere tsusdere marked this pull request as ready for review January 5, 2024 18:56
@tsusdere tsusdere merged commit c27a30c into master Jan 16, 2024
2 checks passed
Copy link

welcome bot commented Jan 16, 2024

Congrats on getting your first pull request to the Minimal theme merged! Without amazing humans like you submitting pull requests, we couldn’t run this project. You rock! 🎉

If you're interested in tackling another bug or feature, take a look at the open issues, especially those labeled help wanted.

Copy link

@janbrasna janbrasna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tsusdere Following up from github/jekyll-commonmark-ghpages#34 (review)

(the above will probably apply to all the repos, themes, plugins where this was copied over)

Comment on lines +80 to +82
## Publishing Gem
In order to publish the Gem bump the version in *this file*, commit, create a tag with the new version number, and finally push the commit and tag to the repo.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"…in this file" — this file is CONTRIBUTING.md — wasn't there supposed to be a link? Probably to the gemspec?

Anyways the workflow isn't tied to tags, but to releases. So the instructions don't seem correct?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants