Numbering post push #75
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hwangcc23
force-pushed
the
numbering-post-push
branch
2 times, most recently
from
57492d3
to
7fbd81a
Compare
Numbering Post-Push is a good function for discussion in one post. See the issue pcman-bbs#42(pcman-bbs#42). 1). Add a field PostPushNum in the line structure. The line structure: struct{ char[ColsPerPage], char='\0', CTermCharAttr[ColsPerPage, char=0]} [ ColsPerPage*char + '\0' + ColsPerPage*CTermCharAttr + PostPushNum ] 2). Detect Post-Push lines and numbering them whenever a character is added in the screen buffer of CTermData. 3). Save the number in PostPushNum of Post-Push lines. 4). Draw PostPushNum in CTermView:DrawChar(). 5). Fix a bug of buffer overflow in CTermData::InsertChar(). p.s. Though the function is not used now.
hwangcc23
force-pushed
the
numbering-post-push
branch
from
7fbd81a
to
0e6b5f4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Numbering Post-Push
Numbering Post-Push is a good function for discussion in one post.
See the issue #42(#42).
1). Add a field PostPushNum in the line structure.
The line structure:
struct{ char[ColsPerPage], char='\0', CTermCharAttr[ColsPerPage, char=0]}
[ ColsPerPage_char + '\0' + ColsPerPage_CTermCharAttr + PostPushNum ]
2). Detect Post-Push lines and numbering them whenever a character is added in the screen buffer of CTermData.
3). Save the number in PostPushNum of Post-Push lines.
4). Draw PostPushNum in CTermView:DrawChar().
5). Fix a bug of buffer overflow in CTermData::InsertChar(). p.s. Though the function is not used now.