Gps and Pps support #1517
Gps and Pps support #1517
Conversation
…mat the company used)
…as the same with the existing code
…s fixed and also each signal is recieved around a second(very accurate) now so that bug is also fixed
… simultaneously(each second) in which we plan to combine them before applying it to the kalman filter. This also confirms that our local clock namely pps is working as expected since the output we have matches with gps data.
…, "parse_nmea_date" and "process_gnrmc" functions.
|
I have yet to join the project; this is not the review you requested. This fork is IMO underdocumented. You have 180 commits (roughly 5x the main branch's progress minus many dependency bumps), and the entire documentation is a few paragraphs in README.md. You could also label the TOML config excerpt as such; there is no indication of which GPS protocols are supported (of ~20, my guess is only a hypothetical version NMEA0183) |
|
@JamesB192 Please be aware that this PR was a student project exploring the GPS and PPS functionality. We've worked closely with them, so we have some context that is unavailable on this PR. This code isn't ready for ntpd-rs, but I believe we were planning to look at this in the coming months. Unfortunately we only have limited budget and time to work on it. |
This is our implementation for Gps and PPS support for NTPD-rs. It also acts as a handover for the Software Project course we followed at Tu Delft.
This pr let's the user configure the port name and measurement noises for gps and pps signals. It then integrates these signals into the existing codebase to aid in determining the true time. It seeks to to close: #882
We look forward to getting a review!