feat: allow empty value for /pgf/arrow keys/fill #1352
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rmano
added a commit
to Rmano/circuitikz
that referenced
this pull request
Jul 15, 2024
muzimuzhi
requested changes
Jul 15, 2024
hmenke
force-pushed
the
arrows
branch
2 times, most recently
from
e96729a
to
d715236
Compare
Signed-off-by: Henri Menke <[email protected]> Co-authored-by: Yukai Chou <[email protected]> Co-authored-by: Romano Giannetti <[email protected]>
muzimuzhi
approved these changes
Jul 19, 2024
Rmano
added a commit
to circuitikz/circuitikz
that referenced
this pull request
Jul 19, 2024
Add a new type of arrow to help drawing Jack connectors Fixes #806 See also pgf-tikz/pgf#1352 Thanks to @Skillmon pgf-tikz/pgf#1348 (comment)
muzimuzhi
reviewed
Jul 19, 2024
| @@ -510,12 +510,14 @@ | |||
| fill/.code={% | |||
| \def\pgf@temp{#1}% | |||
| \ifx\pgf@temp\pgf@nonetext% | |||
| \pgfarrowsaddtooptions{\pgfarrowopentrue} | |||
| \pgfarrowsaddtooptions{\pgfarrowopentrue}% | |||
| \else\ifx\pgf@temp\pgfutil@empty% | |||
There was a problem hiding this comment.
seems consistency beats no more unnecessary % ...
|
@hmenke Do you think this needs a new test? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Fixes #1348
Checklist
Please signoff your commits to explicitly state your agreement to the Developer Certificate of Origin. If that is not possible you may check the boxes below instead: