WIP: Create samples from sequence run #1321
Conversation
| @@ -33,6 +36,10 @@ render( | |||
| <Routes> | |||
| <Route path="/" element={<SequencingRunListPage />} /> | |||
| <Route path="/:runId" element={<SequencingRunDetailsPage />} /> | |||
| <Route | |||
There was a problem hiding this comment.
All of this can be moved up to the admin router
There was a problem hiding this comment.
After talking, I believe we said that we need to retain this for technician access. A new store and routes were created within the admin panel.
Please see 00f9906.
|
|
||
| /* | ||
| Redux Store for sequencing runs. | ||
| For more information on redux stores see: https://redux.js.org/tutorials/fundamentals/part-4-store | ||
| */ | ||
| export default configureStore({ | ||
| reducer: { | ||
| reducer: runReducer, |
There was a problem hiding this comment.
This all should be on the admin store, there should only be one store
There was a problem hiding this comment.
After talking, I believe we said that we need to retain this for technician access. A new store and routes were created within the admin panel.
Please see 00f9906.
| @@ -29,6 +29,11 @@ export const sequencingRunsApi = createApi({ | |||
| query: (runId) => ({ | |||
| url: `${runId}/sequenceFiles`, | |||
| }), | |||
| transformResponse(response, meta) { | |||
There was a problem hiding this comment.
Wondering if this should not be done through a utility class in the controller. Reason I am asking is that another controller might want to get the sequencing files but not need this attribute.
Description of changes
What did you change in this pull request? Provide a description of files changed, user interactions changed, etc. Include how to test your changes.
Related issue
Link to the GitHub issue this pull request addresses using the
#issuenumformat. If it completes an issue, useFixes #issuenumto automatically close the issue.Checklist
Things for the developer to confirm they've done before the PR should be accepted: