backport container aware #7
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dbu
force-pushed
the
backport-container-aware
branch
from
c0e7dff
to
e4839e7
Compare
alexander-schranz
approved these changes
Apr 4, 2024
dbu
force-pushed
the
backport-container-aware
branch
2 times, most recently
from
5dd2c54
to
4de601c
Compare
dbu
commented
Apr 4, 2024
composer.json
Outdated
| "symfony/dependency-injection": "^5.4 || ^6.0 || ^7.0", | ||
| "symfony/http-kernel": "^5.4 || ^6.0 || ^7.0" | ||
| "doctrine/phpcr-bundle": "^1.3 || ^2.0 || ^3.0", | ||
| "symfony/config": "^6.4 || ^7.0", |
There was a problem hiding this comment.
with symfony < 6.4, we end up with a too old version of the symfony-cmf/testing bundle that is not compatible with phpcr-odm 2. is this an acceptable solution for you?
if not i would probably need to backport phpcr-odm 2 support into testing version 4...
There was a problem hiding this comment.
I did have discussion with @chirimoya lately and we did say that we need still support Symfony 5.4 as its a LTS is still running.
Can you conflict the symfony-cmf/testing version?
There was a problem hiding this comment.
ok, i fixed symfony-cmf/testing 4 to work with symfony 5.4 to 7. it was a bit of a mess to figure it out but in the end did not need many hacks.
dbu
force-pushed
the
backport-container-aware
branch
7 times, most recently
from
aab15cd
to
aa39b6d
Compare
dbu
force-pushed
the
backport-container-aware
branch
from
aa39b6d
to
fcc932e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.